Merge pull request #737 from rianquinn/patch-1

Update C.128 to remove override from destructors
This commit is contained in:
Gabriel Dos Reis 2016-09-26 11:39:30 -07:00 committed by GitHub
commit 1894380d0a

View File

@ -6103,7 +6103,7 @@ Readability.
Detection of mistakes. Detection of mistakes.
Writing explicit `virtual`, `override`, or `final` is self-documenting and enables the compiler to catch mismatch of types and/or names between base and derived classes. However, writing more than one of these three is both redundant and a potential source of errors. Writing explicit `virtual`, `override`, or `final` is self-documenting and enables the compiler to catch mismatch of types and/or names between base and derived classes. However, writing more than one of these three is both redundant and a potential source of errors.
Use `virtual` only when declaring a new virtual function. Use `override` only when declaring an overrider. Use `final` only when declaring an final overrider. Use `virtual` only when declaring a new virtual function. Use `override` only when declaring an overrider. Use `final` only when declaring an final overrider. If a base class destructor is declared `virtual`, derived class destructors should neither be declared `virtual` nor `override`.
##### Example, bad ##### Example, bad