StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1087 from leoperezpulido/master

Browse Source 
Typo: add missing semicolon
This commit is contained in:
Andrew Pardoe 2017-11-27 11:06:50 -08:00 committed by GitHub
commit 18578a421a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CppCoreGuidelines.md
View File

@ -679,7 +679,7 @@ You don't need to write error handlers for errors caught at compile time.
for (Int i = 1; i; i <<= 1) for (Int i = 1; i; i <<= 1)
++bits; ++bits;
if (bits < 32) if (bits < 32)
cerr << "Int too small\n" cerr << "Int too small\n";
This example fails to achieve what it is trying to achieve (because overflow is undefined) and should be replaced with a simple `static_assert`: This example fails to achieve what it is trying to achieve (because overflow is undefined) and should be replaced with a simple `static_assert`:
@ -1108,7 +1108,7 @@ Instead, we could use `vector`:
##### Note ##### Note
The standards library and the GSL are examples of this philosophy. The standards library and the GSL are examples of this philosophy.
For example, instead of messing with the arrays, unions, cast, tricky lifetime issues, `gsl::owner`, etc. For example, instead of messing with the arrays, unions, cast, tricky lifetime issues, `gsl::owner`, etc.,
that are needed to implement key abstractions, such as `vector`, `span`, `lock_guard`, and `future`, we use the libraries that are needed to implement key abstractions, such as `vector`, `span`, `lock_guard`, and `future`, we use the libraries
designed and implemented by people with more time and expertise than we usually have. designed and implemented by people with more time and expertise than we usually have.
Similarly, we can and should design and implement more specialized libraries, rather than leaving the users (often ourselves) Similarly, we can and should design and implement more specialized libraries, rather than leaving the users (often ourselves)
@ -1249,7 +1249,7 @@ Reporting through non-local variables (e.g., `errno`) is easily ignored. For exa
// don't: no test of printf's return value // don't: no test of printf's return value
fprintf(connection, "logging: %d %d %d\n", x, y, s); fprintf(connection, "logging: %d %d %d\n", x, y, s);
What if the connection goes down so that no logging output is produced? See I.??. What if the connection goes down so that no logging output is produced? See I.???.
**Alternative**: Throw an exception. An exception cannot be ignored. **Alternative**: Throw an exception. An exception cannot be ignored.