StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

fix cpplint style warnings

Browse Source
This commit is contained in:
Thibault Kruse 2016-04-24 22:31:34 +02:00
parent 7889c89fb4
commit 0ad523eecf
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
CppCoreGuidelines.md
View File

@ -10376,13 +10376,13 @@ Local static variables are a common source of data races.
void f(fstream& fs, regex pat) void f(fstream& fs, regex pat)
{ {
array<double,max> buf; array<double, max> buf;
int sz = read_vec(fs,buf,max); // read from fs into buf int sz = read_vec(fs, buf, max); // read from fs into buf
gsl::span<double> s {buf,max}; gsl::span<double> s {buf, max};
// ... // ...
auto h1 = async([&]{ sort(par,s); }); // spawn a task to sort auto h1 = async([&]{ sort(par, s); }); // spawn a task to sort
// ... // ...
auto h2 = async([&]{ return find_all(buf,sz,pat); }); // span a task to find matches auto h2 = async([&]{ return find_all(buf, sz, pat); }); // span a task to find matches
// ... // ...
} }
@ -10399,7 +10399,7 @@ Not all data races are as easy to spot as this one.
if (val < 5) { if (val < 5) {
// ... other thread can change val here ... // ... other thread can change val here ...
switch(val) { switch (val) {
case 0: // ... case 0: // ...
case 1: // ... case 1: // ...
case 2: // ... case 2: // ...
@ -10764,11 +10764,11 @@ If a `thread` is detached, we can safely pass pointers to static and free store
void some_fct(int* p) void some_fct(int* p)
{ {
int x = 77; int x = 77;
std::thread t0(f,&x); // bad std::thread t0(f, &x); // bad
std::thread t1(f,p); // bad std::thread t1(f, p); // bad
std::thread t2(f,&glob); // OK std::thread t2(f, &glob); // OK
auto q = make_unique<int>(99); auto q = make_unique<int>(99);
std::thread t3(f,q.get()); // bad std::thread t3(f, q.get()); // bad
// ... // ...
t0.detach(); t0.detach();
t1.detach(); t1.detach();
@ -11033,7 +11033,7 @@ Instead, we could have a set of pre-created worker threads processing the messag
void master(istream& is) void master(istream& is)
{ {
for (Message m; is>>m; ) for (Message m; is >> m; )
work.put(n); work.put(n);
} }
@ -11119,8 +11119,8 @@ Here, if some other `thread` consumes `thread1`'s notification, `thread2` can wa
void Sync_queue<T>::get(T& val) void Sync_queue<T>::get(T& val)
{ {
unique_lock<mutex> lck(mtx); unique_lock<mutex> lck(mtx);
cond.wait(lck,[this]{ return !q.empty(); }); // prevent spurious wakeup cond.wait(lck, [this]{ return !q.empty(); }); // prevent spurious wakeup
val=q.front(); val = q.front();
q.pop_front(); q.pop_front();
} }
@ -11336,13 +11336,13 @@ It's error-prone and requires expert level knowledge of language features, machi
extern atomic<Link*> head; // the shared head of a linked list extern atomic<Link*> head; // the shared head of a linked list
Link* nh = new Link(data,nullptr); // make a link ready for insertion Link* nh = new Link(data, nullptr); // make a link ready for insertion
Link* h = head.load(); // read the shared head of the list Link* h = head.load(); // read the shared head of the list
do { do {
if (h->data<=data) break; // if so, insert elsewhere if (h->data <= data) break; // if so, insert elsewhere
nh->next = h; // next element is the previous head nh->next = h; // next element is the previous head
} while (!head.compare_exchange_weak(h,nh)); // write nh to head or to h } while (!head.compare_exchange_weak(h, nh)); // write nh to head or to h
Spot the bug. Spot the bug.
It would be really hard to find through testing. It would be really hard to find through testing.