From 5190032029756fadda793f8f2ef3a332f967664e Mon Sep 17 00:00:00 2001
From: Thomas Hounsell <commit@thounsell.co.uk>
Date: Fri, 19 Aug 2016 19:47:30 +0100
Subject: [PATCH] Fix #70; Don't break front page on nulls

---
 BuildFeed/Models/Build/Build.cs        |  6 +--
 BuildFeed/Views/front/editBuild.cshtml |  2 +-
 BuildFeed/Views/front/index.cshtml     | 69 +++++++++++++++-----------
 3 files changed, 43 insertions(+), 34 deletions(-)

diff --git a/BuildFeed/Models/Build/Build.cs b/BuildFeed/Models/Build/Build.cs
index ff8ed4e..ce8e987 100644
--- a/BuildFeed/Models/Build/Build.cs
+++ b/BuildFeed/Models/Build/Build.cs
@@ -114,7 +114,7 @@ public async Task<FrontPage> SelectFrontPage()
             }
          }).Sort(sortByCompileDate).Limit(1);
 
-         fp.CurrentCanary = (await query.ToListAsync())[0];
+         fp.CurrentCanary = await query.FirstOrDefaultAsync();
 
          query = _buildCollection.Find(new BsonDocument
          {
@@ -138,7 +138,7 @@ public async Task<FrontPage> SelectFrontPage()
             }
          }).Sort(sortByCompileDate).Limit(1);
 
-         fp.CurrentInsider = (await query.ToListAsync())[0];
+         fp.CurrentInsider = await query.FirstOrDefaultAsync();
 
          query = _buildCollection.Find(new BsonDocument
          {
@@ -162,7 +162,7 @@ public async Task<FrontPage> SelectFrontPage()
             }
          }).Sort(sortByCompileDate).Limit(1);
 
-         fp.CurrentRelease = (await query.ToListAsync())[0];
+         fp.CurrentRelease = await query.FirstOrDefaultAsync();
 
          return fp;
       }
diff --git a/BuildFeed/Views/front/editBuild.cshtml b/BuildFeed/Views/front/editBuild.cshtml
index 316a8a2..32f81bf 100644
--- a/BuildFeed/Views/front/editBuild.cshtml
+++ b/BuildFeed/Views/front/editBuild.cshtml
@@ -123,7 +123,7 @@ else
             {
                @class = "form-control"
             })
-            <button onclick="$('#@Html.IdFor(model => model.LeakDate)').val('@DateTime.Now.ToString("dd/MM/yyyy")');return false;" class="btn btn-success btn-block btn-reset">@VariantTerms.Front_Today</button>
+            <button onclick="$('#@Html.IdFor(model => model.LeakDate)').val('@DateTime.Now.ToShortDateString()');return false;" class="btn btn-success btn-block btn-reset">@VariantTerms.Front_Today</button>
             @Html.ValidationMessageFor(model => model.LeakDate)
          </div>
       </div>
diff --git a/BuildFeed/Views/front/index.cshtml b/BuildFeed/Views/front/index.cshtml
index f28446c..af5979a 100644
--- a/BuildFeed/Views/front/index.cshtml
+++ b/BuildFeed/Views/front/index.cshtml
@@ -11,39 +11,48 @@
 
 <h3>@VariantTerms.Front_LatestBuilds</h3>
 <div class="latest-flex">
-   <a href="@Url.Action("ViewBuild", new
+   @if (Model.CurrentCanary != null)
+   {
+      <a href="@Url.Action("ViewBuild", new
             {
                Model.CurrentCanary.Id
             })" class="latest-flex-item latest-flex-red">
-      <h3 class="latest-flex-title">@VariantTerms.Front_CurrentCanary</h3>
-      <div class="latest-flex-detail">
-         <p class="latest-flex-build">@(Model.CurrentCanary.MajorVersion).@(Model.CurrentCanary.MinorVersion).@(Model.CurrentCanary.Number).@(Model.CurrentCanary.Revision)</p>
-         <p class="latest-flex-lab">@Model.CurrentCanary.Lab</p>
-         <p class="latest-flex-time">@Model.CurrentCanary.BuildTime.Value.ToString("HH:mm, dddd dd MMMM yyyy")</p>
-      </div>
-   </a>
-   <a href="@Url.Action("ViewBuild", new
-            {
-               Model.CurrentInsider.Id
-            })" class="latest-flex-item latest-flex-yellow">
-      <h3 class="latest-flex-title">@VariantTerms.Front_CurrentInsider</h3>
-      <div class="latest-flex-detail">
-         <p class="latest-flex-build">@(Model.CurrentInsider.MajorVersion).@(Model.CurrentInsider.MinorVersion).@(Model.CurrentInsider.Number).@(Model.CurrentInsider.Revision)</p>
-         <p class="latest-flex-lab">@Model.CurrentInsider.Lab</p>
-         <p class="latest-flex-time">@Model.CurrentInsider.BuildTime.Value.ToString("HH:mm, dddd dd MMMM yyyy")</p>
-      </div>
-   </a>
-   <a href="@Url.Action("ViewBuild", new
-            {
-               Model.CurrentRelease.Id
-            })" class="latest-flex-item latest-flex-green">
-      <h3 class="latest-flex-title">@VariantTerms.Front_CurrentRelease</h3>
-      <div class="latest-flex-detail">
-         <p class="latest-flex-build">@(Model.CurrentRelease.MajorVersion).@(Model.CurrentRelease.MinorVersion).@(Model.CurrentRelease.Number).@(Model.CurrentRelease.Revision)</p>
-         <p class="latest-flex-lab">@Model.CurrentRelease.Lab</p>
-         <p class="latest-flex-time">@Model.CurrentRelease.BuildTime.Value.ToString("HH:mm, dddd dd MMMM yyyy")</p>
-      </div>
-   </a>
+         <h3 class="latest-flex-title">@VariantTerms.Front_CurrentCanary</h3>
+         <div class="latest-flex-detail">
+            <p class="latest-flex-build">@(Model.CurrentCanary.MajorVersion).@(Model.CurrentCanary.MinorVersion).@(Model.CurrentCanary.Number).@(Model.CurrentCanary.Revision)</p>
+            <p class="latest-flex-lab">@Model.CurrentCanary.Lab</p>
+            <p class="latest-flex-time">@(Model.CurrentCanary.BuildTime?.ToString("HH:mm, dddd dd MMMM yyyy"))</p>
+         </div>
+      </a>
+   }
+   @if (Model.CurrentInsider != null)
+   {
+      <a href="@Url.Action("ViewBuild", new
+               {
+                  Model.CurrentInsider.Id
+               })" class="latest-flex-item latest-flex-yellow">
+         <h3 class="latest-flex-title">@VariantTerms.Front_CurrentInsider</h3>
+         <div class="latest-flex-detail">
+            <p class="latest-flex-build">@(Model.CurrentInsider.MajorVersion).@(Model.CurrentInsider.MinorVersion).@(Model.CurrentInsider.Number).@(Model.CurrentInsider.Revision)</p>
+            <p class="latest-flex-lab">@Model.CurrentInsider.Lab</p>
+            <p class="latest-flex-time">@(Model.CurrentInsider.BuildTime?.ToString("HH:mm, dddd dd MMMM yyyy"))</p>
+         </div>
+      </a>
+   }
+   @if (Model.CurrentRelease != null)
+   {
+      <a href="@Url.Action("ViewBuild", new
+               {
+                  Model.CurrentRelease.Id
+               })" class="latest-flex-item latest-flex-green">
+         <h3 class="latest-flex-title">@VariantTerms.Front_CurrentRelease</h3>
+         <div class="latest-flex-detail">
+            <p class="latest-flex-build">@(Model.CurrentRelease.MajorVersion).@(Model.CurrentRelease.MinorVersion).@(Model.CurrentRelease.Number).@(Model.CurrentRelease.Revision)</p>
+            <p class="latest-flex-lab">@Model.CurrentRelease.Lab</p>
+            <p class="latest-flex-time">@(Model.CurrentRelease.BuildTime?.ToString("HH:mm, dddd dd MMMM yyyy"))</p>
+         </div>
+      </a>
+   }
 </div>
 <a href="@Url.Action("IndexPage", new
          {